Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bpk-component-popover] Flow-types in npm module #1118

Closed
ErlendS opened this issue Oct 19, 2018 · 3 comments
Closed

[bpk-component-popover] Flow-types in npm module #1118

ErlendS opened this issue Oct 19, 2018 · 3 comments

Comments

@ErlendS
Copy link

ErlendS commented Oct 19, 2018

Hi, I'm having trouble using bpk-component-popover because it ships with flowtypes in the .js files.

It would've been simple to strip them with a babel loader I guess, but in a TS project we do not have the option of using loaders. Is there any way you can bundle pure js files and move flow definitions to a separate file?

@arnaugm
Copy link
Contributor

arnaugm commented Sep 22, 2019

A project created with CRA also have problems with Flow in the dependencies. CRA provides support for Flow out of the box but for some reason it doesn't work with dependencies, any solutions for this?

@olliecurtis
Copy link
Member

Hello 👋

Its been a while but in the future we are exploring the possibility of shipping our components transpiled so this issue should hopefully disappear once this happens 😄

Hope that helps

@olliecurtis
Copy link
Member

Closing this as this has been some time but feel free to re-open if you have any further issues or concerns

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants