Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Poison the database by default if snapshotting fails #160

Merged
merged 2 commits into from
May 30, 2021
Merged

Commits on May 29, 2021

  1. Stop accepting writes if snapshotting fails

    This is an important consideration: if BGSAVE fails and poisons the
    database, snapshotting can and should too. But this is debatable in some
    parts. For example, users may configure snapshots to be on a network
    file system (symlinked maybe) and this can fail.
    Now in some cases, this failure 'may be acceptable'. This commit adds a
    way to customize this behavior through the `failsafe` key in the
    snapshots section of the cfg file and through the --stop-write-on-fail
    option passed to `skyd` on startup. However, BGSAVE remains unchanged:
    it will always poison the database if it fails. If the user doesn't want
    this, they can simply disable BGSAVE.
    ohsayan committed May 29, 2021
    Configuration menu
    Copy the full SHA
    55c1882 View commit details
    Browse the repository at this point in the history

Commits on May 30, 2021

  1. Add changelog

    ohsayan committed May 30, 2021
    Configuration menu
    Copy the full SHA
    e6c85a3 View commit details
    Browse the repository at this point in the history