Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deter other processes from using the same data dir #169

Merged
merged 2 commits into from
Jun 12, 2021

Conversation

ohsayan
Copy link
Member

@ohsayan ohsayan commented Jun 12, 2021

Closes #167

@glydr glydr added D-server Related to the server D-docs labels Jun 12, 2021
@ohsayan ohsayan added A-independent Architecture independent issue/PR C-bug Something isn't working C-storage Relating to storage labels Jun 12, 2021
Windows has mandatory locking so second instance won't be able to read
the PID of the other process. We'll just keep the file descriptor/handle
open
@ohsayan
Copy link
Member Author

ohsayan commented Jun 12, 2021

@glydr rsquash

Copy link
Collaborator

@glydr glydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw approval and instant squash merge request from @ohsayan

@glydr glydr merged commit ca9e482 into next Jun 12, 2021
@ohsayan ohsayan deleted the fix/diskstore/multipid branch October 10, 2021 02:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-independent Architecture independent issue/PR C-bug Something isn't working C-storage Relating to storage D-docs D-server Related to the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Server: Running two skyd in same directory can lead to loss of data
2 participants