Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new snapshot engine #198

Merged
merged 3 commits into from
Aug 12, 2021
Merged

Implement new snapshot engine #198

merged 3 commits into from
Aug 12, 2021

Conversation

ohsayan
Copy link
Member

@ohsayan ohsayan commented Aug 8, 2021 •
edited

No description provided.

@ohsayan ohsayan added C-enhancement New feature or request required-improvement This issue or PR addresses an already existing implementation that needs to be revised D-server Related to the server P-high High priority C-storage Relating to storage C-tests This is related to the test suite L-Hard Requires a "huge" amount of effort C-reliability This issue/PR relates to reliability labels Aug 8, 2021
@glydr glydr added the D-cargo Cargo configuration/dependency related issue/PR label Aug 9, 2021
@ohsayan ohsayan marked this pull request as ready for review August 12, 2021 02:38
@ohsayan
Copy link
Member Author

ohsayan commented Aug 12, 2021

Looking good on most tests except M1 (spurious?). Anyways, @glydr r+

glydr
glydr approved these changes Aug 12, 2021
View reviewed changes
Copy link
Collaborator

@glydr glydr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw approval from @ohsayan

@ohsayan ohsayan merged commit 01b72a5 into next Aug 12, 2021
@ohsayan ohsayan deleted the storage/snapshotengine branch August 12, 2021 03:01
ohsayan added a commit that referenced this pull request Aug 12, 2021
@ohsayan
Merge pull request #198 from skytable/storage/snapshotengine
1092bdf
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glydr glydr glydr approved these changes

Assignees
No one assigned
Labels
C-enhancement New feature or request C-reliability This issue/PR relates to reliability C-storage Relating to storage C-tests This is related to the test suite D-cargo Cargo configuration/dependency related issue/PR D-server Related to the server L-Hard Requires a "huge" amount of effort P-high High priority required-improvement This issue or PR addresses an already existing implementation that needs to be revised
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ohsayan @glydr