Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BQL,QE,SE: Add UPSERT query, BQL query shorthands and fix SE bootup crash #342

Merged
merged 6 commits into from Apr 18, 2024

Conversation

ohsayan
Copy link
Member

@ohsayan ohsayan commented Apr 17, 2024

  • Add BlueQL shorthands for DML queries
  • Added UPSERT (update or insert) query
  • Fixed SE memory bug (only affects startup)

@ohsayan ohsayan added D-server Related to the server C-tests This is related to the test suite labels Apr 17, 2024
@ohsayan ohsayan force-pushed the queries/upsert branch 2 times, most recently from d4f3255 to 33abc1c Compare April 17, 2024 18:38
@ohsayan
Copy link
Member Author

ohsayan commented Apr 17, 2024

Error on 32-bit MSVC is due to stack overflow. Adjusting stack size doesn't seem to have any effect. Will switch to single-thread for now.

@ohsayan
Copy link
Member Author

ohsayan commented Apr 17, 2024

Also, running tests individually doesn't cause any issues (tested on W11; cross-compiled to 32-bit target)

@ohsayan
Copy link
Member Author

ohsayan commented Apr 18, 2024

Was able to reproduce this locally on a Windows machine. Changing stack size doesn't help at all. There's an issue, most likely with the thread-local for stashed objects becoming too large but if it can't handle our test suite it'd unlikely be able to perform well in production. Hence, Windows 32-bit has been downgraded to Tier-2 and will most likely be deprecated in the future, probably around 0.9. We're moving towards 64-bit only support and given that probably all of our deployments will run exclusively on 64-bit platforms it doesn't make much sense to continue support 32-bit (and given that they're limited to 4GB memory which doesn't make sense for an in-memory database).

Even RPIs have 64-bit ISAs now!

@ohsayan ohsayan marked this pull request as ready for review April 18, 2024 14:41
@ohsayan ohsayan merged commit 5eea3e4 into next Apr 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-tests This is related to the test suite D-server Related to the server
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant