Use binary for building docker image #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the previous workflow, we were building and testing twice: once for the docker image and once for the test step. Now, we'll build a debug version in the test step, then build a release version and finally copy that into the docker image. This would heavily reduce our build times. Signed-off-by: Sayan Nandan <nandansayan@outlook.com>
Signed-off-by: Sayan Nandan <nandansayan@outlook.com>
Signed-off-by: Sayan Nandan <nandansayan@outlook.com>
ohsayan
added
D-build
Since both conditions have to evaluate to true, we'll need to use refs while also matching against both `push` and `tag` events Signed-off-by: Sayan Nandan <nandansayan@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the previous workflow, we were building and testing twice: once for the docker image and once for the test step. Now, we'll build a debug version in the test step, then build a release version and finally copy that into the docker image. This would heavily reduce our build times.
Related: #39