unexpected action sheet dismissing in portrait mode only #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The problem with that code is that it only works for portrait to landscape. What about the reverse? |
|
@numen31337 Your're right. But before merge I would like to improve your code to support not only For example: your code doesn't work in case when I set supported device orientation to Landscape left. |
|
yep, you are right, sorry for fix only for my case, I was so wondering why it disappeared while I'm selecting :) |
skywinder
added a commit
that referenced
this pull request
Sep 17, 2014
|
@numen31337 I updated your code. Now it works for all orientations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently if my application support only portrait mode and I rotate the device, picker is dismissing unexpectedly