Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Memory Leak & Fix import #561

Merged
merged 5 commits into from
Mar 18, 2024
Merged

Fix Memory Leak & Fix import #561

merged 5 commits into from
Mar 18, 2024

Conversation

mlch911
Copy link

@mlch911 mlch911 commented Jan 3, 2024

Fix import using CocoaPods.
Fix dismiss function not called in iPad.
Fix Memory Leak.

@skywinder
Copy link
Owner

Thanks for the update, @mlch911!

I am no longer supporting this library, as I am now 100% focused on blockchain R&D and audits at my company, where I dedicate all my time www.oxor.io.

I appreciate your willingness to help with the project. I can add you to the list of contributors, so you can keep it alive if you're willing to continue its development.

P.S.
Here is an update about adding collaborators. Ping me if you're willing to keep it going.
#348

@Wei18
Copy link
Collaborator

Wei18 commented Mar 16, 2024

Hi @mlch911,
Please fix conflicts, thanks.

@mlch911
Copy link
Author

mlch911 commented Mar 16, 2024

Thanks for the update, @mlch911!

I am no longer supporting this library, as I am now 100% focused on blockchain R&D and audits at my company, where I dedicate all my time www.oxor.io.

I appreciate your willingness to help with the project. I can add you to the list of contributors, so you can keep it alive if you're willing to continue its development.

P.S. Here is an update about adding collaborators. Ping me if you're willing to keep it going. #348

Would be nice to help. Sorry for the late reply. @skywinder

# Conflicts:
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/AbstractActionSheetPicker.m
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetCustomPicker.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetCustomPickerDelegate.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetDatePicker.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetDistancePicker.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetLocalePicker.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetMultipleStringPicker.h
#	CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetStringPicker.h
@mlch911
Copy link
Author

mlch911 commented Mar 16, 2024

Hi @mlch911, Please fix conflicts, thanks.

@Wei18 Done.

@Wei18
Copy link
Collaborator

Wei18 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

@Wei18 Wei18 merged commit e70a84a into skywinder:develop Mar 18, 2024
@Wei18 Wei18 linked an issue Mar 18, 2024 that may be closed by this pull request
@mlch911
Copy link
Author

mlch911 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

@Wei18
Copy link
Collaborator

Wei18 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok.
Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

@mlch911
Copy link
Author

mlch911 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

@Wei18
Copy link
Collaborator

Wei18 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

@mlch911
Copy link
Author

mlch911 commented Mar 18, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

Xcode 15.2, Cocoapods 1.11.3, haven't run pod install.
I Just use the Demo Project ActionSheetPicker-3.0.xcworkspace. At this commit 6a913a7ca489a8565afcf85c62a5a9d055934711 and build.
image

@Wei18
Copy link
Collaborator

Wei18 commented Mar 19, 2024

We still need fix warns (about import) after this PR merged.

I have modified the import method. Do I need to change it again?

It's ok. Some users who partially use Cocoapods encountered errors. Your recent changes have turned these errors into warnings, so we can address these warnings later.

I encountered these errors too. So I changed it.

Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml .

Xcode 15.2, Cocoapods 1.11.3, haven't run pod install. I Just use the Demo Project ActionSheetPicker-3.0.xcworkspace. At this commit 6a913a7ca489a8565afcf85c62a5a9d055934711 and build. image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in v2.7.3 compilation issue
3 participants