-
-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Memory Leak & Fix import #561
Conversation
Thanks for the update, @mlch911! I am no longer supporting this library, as I am now 100% focused on blockchain R&D and audits at my company, where I dedicate all my time www.oxor.io. I appreciate your willingness to help with the project. I can add you to the list of contributors, so you can keep it alive if you're willing to continue its development. P.S. |
Hi @mlch911, |
Would be nice to help. Sorry for the late reply. @skywinder |
# Conflicts: # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/AbstractActionSheetPicker.m # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetCustomPicker.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetCustomPickerDelegate.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetDatePicker.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetDistancePicker.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetLocalePicker.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetMultipleStringPicker.h # CoreActionSheetPicker/CoreActionSheetPicker/Pickers/include/ActionSheetStringPicker.h
We still need fix warns (about import) after this PR merged. |
I have modified the import method. Do I need to change it again? |
It's ok. |
I encountered these errors too. So I changed it. |
Could you provide workspace_example.zip and information about (xcode version, coaoapod version), let me reproduce this issue. I wanna update CI_build.yml . |
Xcode 15.2, Cocoapods 1.11.3, haven't run |
|
Fix import using CocoaPods.
Fix dismiss function not called in iPad.
Fix Memory Leak.