Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support ST-20 #103

Closed
BaldyAsh opened this issue Nov 26, 2018 · 25 comments · Fixed by #130
Closed

Support ST-20 #103

BaldyAsh opened this issue Nov 26, 2018 · 25 comments · Fixed by #130
Labels
enhancement New feature or request wait for reply

Comments

@BaldyAsh
Copy link
Collaborator

BaldyAsh commented Nov 26, 2018 •
edited

ST-20 token is an Ethereum-based token implemented on top of the ERC-20 protocol that adds the ability for tokens to control transfers based on specific rules.
Its description: https://github.com/PolymathNetwork/polymath-core.
Look at how there are implemented ERC-20 and ERC-721 in https://github.com/matterinc/web3swift/tree/develop/web3swift/PrecompiledContracts.
@BaldyAsh BaldyAsh added the enhancement New feature or request label Nov 26, 2018
@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This issue now has a funding of 60.0 DAI (60.0 USD @ $1.0/DAI) attached to it.

@gitcoinbot
Copy link

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@srisankethu
Copy link

I have submitted a WIP PR -> #116. Will be updating it.

@gitcoinbot
Copy link

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@srisankethu due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@srisankethu
Copy link

Sorry for the delay. I am working on it 👍

@srisankethu
Copy link

@BaldyAsh I have submitted a WIP PR #116. How do I test it?

@gitcoinbot
Copy link

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

@srisankethu due to inactivity, we have escalated this issue to Gitcoin's moderation team. Let us know if you believe this has been done in error!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@BaldyAsh
Copy link
Collaborator Author

@srisankethu hi! Sorry for so long answer, hard days. Currently I can't find any ST-20 token, will try in next few days. But you can create token that quasi-supports ST-20 on test network and use it for testing. If it will be too hard, I'll find another solution

@srisankethu
Copy link

srisankethu commented Jan 26, 2019 •
edited

@BaldyAsh Am I in the right direction #116 ?

@BaldyAsh
Copy link
Collaborator Author

@srisankethu yes, looks fine

@srisankethu
Copy link

@BaldyAsh But how do I test my changes? I think this PR is going nowhere :(

@gitcoinbot
Copy link

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

1 similar comment
@gitcoinbot
Copy link

gitcoinbot commented Feb 1, 2019 •
edited by BaldyAsh

@srisankethu Hello from Gitcoin Core - are you still working on this issue? Please submit a WIP PR or comment back within the next 3 days or you will be removed from this ticket and it will be returned to an ‘Open’ status. Please let us know if you have questions!

  • reminder (3 days)
  • escalation to mods (6 days)

Funders only: Snooze warnings for 1 day | 3 days | 5 days | 10 days | 100 days

@BaldyAsh
Copy link
Collaborator Author

BaldyAsh commented Feb 5, 2019

@srisankethu There is only way - create your mocked ST-20 token and use it for tests. Sorry, but I can't find any ST-20 token for testing, sent the message to Polymath but still no answer.

@srisankethu
Copy link

@BaldyAsh Should I leave this task then!? This PR is going nowhere. Wasted my time on this

@BaldyAsh
Copy link
Collaborator Author

BaldyAsh commented Feb 5, 2019

@srisankethu sure, leave it. Thank you for trying to complete it

@gitcoinbot
Copy link

gitcoinbot commented Mar 4, 2019 •
edited

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

Work has been started.

These users each claimed they can complete the work by 1 month, 1 week ago.
Please review their action plans below:

1) baldyash has been approved to start work.

  • mock st-20 token or find one for tests
  • list functions for working with st-20 tokens
  • implement them

Learn more on the Gitcoin Issue Details page.

@BaldyAsh
Copy link
Collaborator Author

BaldyAsh commented Mar 5, 2019

@ceresstation please, approve

@BaldyAsh BaldyAsh mentioned this issue Mar 15, 2019
Merged
@BaldyAsh
Copy link
Collaborator Author

Made #130 that should close it

@gitcoinbot
Copy link

⚡️ A tip worth 60.00000 DAI (60.0 USD @ $1.0/DAI) has been granted to @BaldyAsh for this issue from @ceresstation. ⚡️

Nice work @BaldyAsh! Your tip has automatically been deposited in the ETH address we have on file.

@gitcoinbot
Copy link

Issue Status: 1. Open 2. Started 3. Submitted 4. Done

This Bounty has been completed.

Additional Tips for this Bounty:

  • ceresstation tipped 60.0000 DAI worth 60.0 USD to BaldyAsh.

@BaldyAsh
Copy link
Collaborator Author

@ceresstation thank you, received the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request wait for reply
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WIP: ST-20 and Security Token support web3swift-team/web3swift
3 participants
@srisankethu @gitcoinbot @BaldyAsh