Remove unused lint rules #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These rules that make linter looser are not used so can just remove them. We can add them back when they become necessary. The only usage of `any` is `AttributeMap`. This PR changes it to `unknown`, which can represent any types like `any` but requires type assertions or control flow based narrowing. It can be considered as a type-safe version of `any` and as a library, it's better to use it instead of `any` to avoid users from writing type-unsafe code. However, this introduces a breaking change for TypeScript users as they have to change their code to either narrowing the types explicitly or using `as any` as we currently do for them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These rules that make linter looser are not used so can just remove them.
We can add them back when they become necessary.
Breaking changes
The only usage of
anyisAttributeMap. This PR changes it tounknown,which can represent any types like
anybut requires type assertions or controlflow based narrowing. It can be considered as a type-safe version of
anyand as a library, it's better to use it instead ofanyto avoid users from writing type-unsafe code.However, this introduces a breaking change for TypeScript users as they have to change their code to either narrowing the types explicitly or using
as anyas we currently do for them.Test plan
Make sure lint passes.