-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
User member is pointer in TeamJoinEvent #30
Comments
I think this all depends on whether the user is a required field or an optional field. If it's required, it should not be a pointer. If it's optional, it should be a pointer. |
Not sure how you mean "required": it's data sent by Slack (always present for both events and probably for others too) so there's nothing optional about it. |
For consistency and Least Surprise it's nice if the TeamJoinEvent also returns a `User`. See https://github.com/nlopes/slack/issues/30
I think the |
Implement RTM ping/pong, and error handling
Hi,
I just noticed an inconsistency where the
UserChangeEvent
includes aUser
(https://github.com/nlopes/slack/blob/master/websocket_misc.go#L40) whereasTeamJoinEvent
uses a*User
(https://github.com/nlopes/slack/blob/master/websocket_teams.go#L5). Not sure which is better but it'd be great if it was consistent! :)The text was updated successfully, but these errors were encountered: