Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

slackevents: MessageEvent missing "Root" field for thread_broadcast SubType #792

Closed
theckman opened this issue Sep 7, 2020 · 0 comments · Fixed by #793
Closed

slackevents: MessageEvent missing "Root" field for thread_broadcast SubType #792

theckman opened this issue Sep 7, 2020 · 0 comments · Fixed by #793

Comments

@theckman
Copy link
Contributor

theckman commented Sep 7, 2020

Ran into an issue with the Slackbot for the community workspace, where it blew up with endless replies because it was unable to determine that a message with SubType thread_broadcast originated from itself. This looks to be because the root field isn't present on the slackevents.MessageEvent type, and I need to use that UserID to properly identify who sent it:

I believe this could be fixed by adding the following to the MessageEvent struct:

// Root is the message that was broadcast to the channel when the SubType is thread_broadcast. If this is not a thread_broadcast this value is likely nil.
Root *MessageEvent `json:"root"`
theckman added a commit to theckman/slack that referenced this issue Sep 7, 2020
@theckman
Add Root field to MessageEvent to support thread_broadcast subtype
cc68d5e 
The `thread_broadcast` subtype includes extra data in the MessageEvent that
we're currently losing, the `root` field. This is where it puts the message that
is being shared to a channel as a reply to a thread.

Fixes slack-go#792
theckman added a commit to theckman/slack that referenced this issue Sep 7, 2020
@theckman
Add Root field to MessageEvent to support thread_broadcast subtype
f4af079 
The `thread_broadcast` subtype includes extra data in the MessageEvent that
we're currently losing, the `root` field. This is where it puts the message that
is being shared to a channel as a reply to a thread.

Fixes slack-go#792
This was referenced Sep 7, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add Root field to MessageEvent to support thread_broadcast subtype theckman/slack
1 participant
@theckman