Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support remote files API #1058

Merged
merged 10 commits into from May 3, 2022

Conversation

dleviminzi
Copy link
Contributor

I would like to revive @ledmonster's effort to add remote file support.

@kanata2 kanata2 changed the title Feature/remote file update Support remote files API Apr 22, 2022
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Please see this comment and update GoDoc.
#859 (comment)

remotefiles.go Outdated Show resolved Hide resolved
@kanata2 kanata2 added feedback given When a review has been conducted and awaiting the response from the comitter(s) enhancement labels Apr 22, 2022
@dleviminzi
Copy link
Contributor Author

Thanks.

Please see this comment and update GoDoc. #859 (comment)

I made the change to the return parameters. I'm not sure what you mean when you ask me to update the GoDoc. Are some explanations not detailed enough or something else?

@dleviminzi dleviminzi requested a review from kanata2 April 22, 2022 13:11
@kanata2
Copy link
Member

kanata2 commented Apr 22, 2022

@dleviminzi

Please add official API documentation's link 🙏

e.g.

slack/chat.go

Lines 185 to 189 in 03f86be

// UnfurlMessageWithAuthURL sends an unfurl request containing an
// authentication URL.
// For more details see:
// https://api.slack.com/reference/messaging/link-unfurling#authenticated_unfurls
func (api *Client) UnfurlMessageWithAuthURL(channelID, timestamp string, userAuthURL string, options ...MsgOption) (string, string, string, error) {

Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@dleviminzi
Copy link
Contributor Author

LGTM. Thanks!

Apologies, I forgot to update the example when I changed the return arguments.

@dleviminzi dleviminzi requested a review from kanata2 April 25, 2022 13:49
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dleviminzi
Copy link
Contributor Author

👍

Hello, when will this be able to get merged?

@kanata2 kanata2 merged commit 0e14c9d into slack-go:master May 3, 2022
@kanata2 kanata2 removed the feedback given When a review has been conducted and awaiting the response from the comitter(s) label May 3, 2022
@kanata2
Copy link
Member

kanata2 commented May 3, 2022

merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants