New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Rich Text Lists #1155
Add support for Rich Text Lists #1155
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great. I produced almost identical code and then realised that there is an existing PR already. Good job! 🚀
Co-authored-by: SimonLiuRoblox <84740141+SimonLiuRoblox@users.noreply.github.com>
68193e4
to
0f23d87
Compare
@PierekEast would you mind triggering the workflow? I've updated the PR so it hopefully passes the linter :) |
Not sure I can do that 🤔 |
Any updates here? Are there workarounds to using RichText lists? |
@david4shure Right now slack-go/slack is essentially unmaintained. I can add new maintainers, and have done some maintaining work in the past, but really what's needed is a current/daily Go developer with some open source experience, and ideally someone familiar with the programming patterns in this library. I haven't the expertise nor the time to stay on top of PR reviews and discussions. I did, however, close + reopen so the tests would run, and apparently the linting test failed. |
Hi team. Could you please make this mergeable? My work is waiting for this to be completed. |
Hey guys, I did fixed the linting problem locally, but I cannot push to the @daniel-pieper-personio branch. Ideally, @daniel-pieper-personio - you could quickly change that and the linter should pass and then everybody will be happy :D There was some whitespace that the go linter did not like: If anyone knows how I could apply these changes to this repo, apart from taking everything from this branch and creating a separate PR, then I would appreciate being enlightened. But in the end, I could do the above and mention that PR as a duplicate. Cheers! |
@nlopes I summon you. Only you can save the world! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks harmless / useful. Approving.
Note that this library needs more maintainers. I'll occasionally review/merge, but don't consider myself qualified since I'm down to <100 lines of Go / year at this point. The only good thing about me is I occasionally respond. |
This PR adds support for rich text lists.
For example:
Reference: https://api.slack.com/changelog/2019-09-what-they-see-is-what-you-get-and-more-and-less