Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Video Block #1210

Merged
merged 3 commits into from Oct 21, 2023
Merged

Add Video Block #1210

merged 3 commits into from Oct 21, 2023

Conversation

walkure
Copy link
Contributor

@walkure walkure commented Jul 8, 2023

Add the support for Video Block.

Ref. https://api.slack.com/reference/block-kit/blocks#video

cf. #1205

@ben-bourdin451 ben-bourdin451 mentioned this pull request Oct 3, 2023
Closed
ben-bourdin451
ben-bourdin451 approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@ben-bourdin451 ben-bourdin451 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW I tested this locally and it works

block_video.go Show resolved Hide resolved
@kholisrag
Copy link

kholisrag commented Oct 17, 2023 •
edited

@kanata2
seem I need this too

@parsley42 parsley42 marked this pull request as draft October 17, 2023 18:31
@parsley42 parsley42 marked this pull request as ready for review October 17, 2023 18:31
@parsley42 parsley42 closed this Oct 17, 2023
@parsley42 parsley42 reopened this Oct 17, 2023
@parsley42
Copy link
Member

Close/re-open to run checks.

@parsley42
Copy link
Member

@ben-bourdin451 This project is currently looking for maintainers; I've been filling in on occasion as I have time, but I probably write 10 lines of Go/month so I'm not the best candidate - I just try to find/recruit maintainers. Are you interested in helping out? Seems like a manageable level of effort.

@ben-bourdin451
Copy link
Contributor

@ben-bourdin451 This project is currently looking for maintainers; I've been filling in on occasion as I have time, but I probably write 10 lines of Go/month so I'm not the best candidate - I just try to find/recruit maintainers. Are you interested in helping out? Seems like a manageable level of effort.

sure, happy to help where ever I can. I don't have a huge amount of spare time but I can definitely help out on triage or reviews here and there

@parsley42 @ben-bourdin451
Update block_video.go
b80fc08 
No harm, definitely useful.

Co-authored-by: Ben Bourdin <ben-bourdin451@users.noreply.github.com>
parsley42
parsley42 approved these changes Oct 19, 2023
View reviewed changes
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@parsley42
Copy link
Member

@ben-bourdin451 Ok, I've sent you an invite. Do you mind having a look at why the tests are failing?

@ben-bourdin451 ben-bourdin451 merged commit e715221 into slack-go:master Oct 21, 2023
4 checks passed
@walkure walkure deleted the add-VideoBlock branch November 8, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ben-bourdin451 ben-bourdin451 ben-bourdin451 approved these changes

@parsley42 parsley42 parsley42 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@walkure @kholisrag @parsley42 @ben-bourdin451