Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add block element type FileInput #1249

Merged
merged 2 commits into from Feb 10, 2024

Conversation

elct9620
Copy link
Contributor

@elct9620 elct9620 commented Dec 20, 2023

Make file_input element is supported.

Related to #1246

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests.

All passed

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes
  • Add slack.NewFileInputBlockElement() to create the file input element.
  • Add Files field to BlockAction
Examples of API changes that do not meet guidelines:

N/A

@parsley42 parsley42 closed this Feb 10, 2024
@parsley42 parsley42 reopened this Feb 10, 2024
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks straight-forward.

@parsley42 parsley42 merged commit ceb2250 into slack-go:master Feb 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants