Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add connected_team_ids optional field to Conversation #1253

Merged
merged 1 commit into from Jan 29, 2024

Conversation

zFlabmonsta
Copy link
Contributor

@zFlabmonsta zFlabmonsta commented Jan 20, 2024

Adding connected_team_ids to Conversation struct.

When conversation.info is called, the response comes with a list of team_ids that are connected to the channel. Currently some fields from the response are missing from Conversation struct.

connected_team_ids
internal_team_ids
shared_team_ids
is_global_shared

image

@zFlabmonsta
Copy link
Contributor Author

👋 @parsley42, could i get this pr reviewed 🙇

Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doesn't look harmful.

@parsley42 parsley42 merged commit 07c76ba into slack-go:master Jan 29, 2024
4 checks passed
@parsley42
Copy link
Member

@zFlabmonsta Ok, this is pretty trivial and obviously not harmful, so I'm ok approving/merging. However, slack-go/slack is not currently actively maintained. I'm not actively developing in Go, so I'm looking for volunteers. Interested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants