Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: always add context to errors during block serde #1259

Merged
merged 1 commit into from Feb 10, 2024
Merged

Fix: always add context to errors during block serde #1259

merged 1 commit into from Feb 10, 2024

Conversation

yunginnanet
Copy link
Contributor

Maintains consistency with existing code:

slack/block_conv.go

Lines 213 to 215 in 86cd1bd

default:
return fmt.Errorf("unsupported block element type %v", blockElementType)
}

Adds critical context to errors during the many headaches joys of developing with the slack block kit.

Signed-off-by: kayos@tcp.direct <kayos@tcp.direct>
Copy link
Member

@parsley42 parsley42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks simple/useful enough.

@parsley42 parsley42 merged commit 15f367e into slack-go:master Feb 10, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants