add functions.completeError and functions.completeSuccess #1301
Conversation
lorenzoaiello
added
enhancement
example
There was a problem hiding this comment.
Thanks for jumping on that issue so quickly @yogasw ! This looks like a great start, but I've left a few comments to double-check - I'm not super familiar with Slack functions so forgive me if I ask some extra questions to make sure I've understood things correctly. If you could also add some tests for both the inner_events and function_event files, I'd appreciate it!
| Type string `json:"type"` | ||
| Name string `json:"name"` | ||
| Description string `json:"description"` | ||
| Title string `json:"title"` |
There was a problem hiding this comment.
I believe there is a IsRequired parameter in the OutputParameter returned in the Function Event based on the example event provided in the documentation.
There was a problem hiding this comment.
but why when I activate debug mode this value is not there?
https://gist.github.com/yogasw/65d68c081bfd5bea14520cedc907a979
| } | ||
|
|
||
| // Function is a struct for functions in FunctionExecuted events | ||
| type Function struct { |
There was a problem hiding this comment.
Where did you find the documentation for FormEnabled and DateReleased? I don't see it on the event documentation page.
There was a problem hiding this comment.
I got it from the debug mode of the slack-go socket mode, because before that I had not found the official documentation
https://gist.github.com/yogasw/65d68c081bfd5bea14520cedc907a979
| @@ -0,0 +1,83 @@ | |||
| package slack | |||
There was a problem hiding this comment.
Please ensure that the WebAPI functions accept a context as the first function parameter and rename this FunctionCompleteErrorContext. You can create a second function called FunctionCompleteError that explicitly sets contact.Background() if you'd like.
You can look at ListEventAuthorizationsContext and ListEventAuthorizations for an example of how to implement it.
| } | ||
|
|
||
| // FunctionCompleteSuccess indicates function is completed | ||
| func (api *Client) FunctionCompleteSuccess(functionExecutionId string, options ...FunctionCompleteSuccessRequestOption) error { |
There was a problem hiding this comment.
I believe the API method returns a customer_id, please add it as a function output to most closely mirror the published API specification.
lorenzoaiello
added
missing test
this PR to handle event function_executed and response the function with functions.completeSuccess and functions.completeError