Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reminders.list api call implemented #812

Merged
merged 6 commits into from
Oct 14, 2020

Conversation

KarolisKl
Copy link
Contributor

Pull Request Guidelines

These are recommendations for pull requests.
They are strictly guidelines to help manage expectations.

PR preparation

Run make pr-prep from the root of the repository to run formatting, linting and tests. (passed)

Should this be an issue instead
  • is it a convenience method? (no new functionality, streamlines some use case)
  • exposes a previously private type, const, method, etc.
  • is it application specific (caching, retry logic, rate limiting, etc)
  • is it performance related.
API changes

Since API changes have to be maintained they undergo a more detailed review and are more likely to require changes.

  • no tests, if you're adding to the API include at least a single test of the happy case.
  • If you can accomplish your goal without changing the API, then do so.
  • dependency changes. updates are okay. adding/removing need justification.
Examples of API changes that do not meet guidelines:
  • in library cache for users. caches are use case specific.
  • Convenience methods for Sending Messages, update, post, ephemeral, etc. consider opening an issue instead.

Description:

Implementation for https://api.slack.com/methods/reminders.list

Some changes in reminders.go:

  • remindersResp struct for reminders.list response
  • doReminders function for sending API request expecting reminders response mentioned above
  • ListReminders function which calls the api request and returns reminders for the user
  • One test added (since the call takes only the token parameter not much you can test there)

reminders.go Outdated Show resolved Hide resolved
KarolisKl and others added 2 commits October 2, 2020 15:09
Co-authored-by: Naoki Kanatani <k12naoki@gmail.com>
reminders.go Outdated Show resolved Hide resolved
KarolisKl and others added 2 commits October 6, 2020 11:49
Co-authored-by: Naoki Kanatani <k12naoki@gmail.com>
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM👍

@kanata2 kanata2 merged commit 2f3e31d into slack-go:master Oct 14, 2020
@KarolisKl KarolisKl mentioned this pull request Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants