Change type of ExcludeArchived
field to bool in GetConversationsParameters
#832
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the type
GetConversationsParameters
by mistake has astring
type forExcludeArchived
property while in the style of this library is to usebool
values for flags and then convert it usingstrconv.FormatBool()
.The fix is quite simple, but it's a breaking change, so I'm not sure what would be the proper flow to incorporate this PR in the terms of the repository.