Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the unnecessary parameter from SetUserRealName and update optional param handling in profile setting #868

Merged

Conversation

sryoya
Copy link
Contributor

@sryoya sryoya commented Dec 11, 2020

PR preparation

Fixes #867
Fixes #809

optional

add handling for optional param in SetUserRealNameContextWithUser

make "user" field optional in SetUserCustomStatusContextWithUser
@sryoya sryoya force-pushed the remove_user_parameter_from_-SetUserRealName branch from 6ba92c5 to ba3451d Compare December 11, 2020 09:43
@sryoya sryoya changed the title Remove the unnecessary parameter from SetUserRealName Remove the unnecessary parameter from SetUserRealName and update optional param handling in profile setting Dec 11, 2020
Copy link
Member

@kanata2 kanata2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@kanata2 kanata2 merged commit a0e6f30 into slack-go:master Dec 11, 2020
@sryoya sryoya deleted the remove_user_parameter_from_-SetUserRealName branch December 11, 2020 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants