New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow message unfurling with auth URL #882
Conversation
Should also add these so I can authenticate users in unfurling flows as described here: flow: https://api.slack.com/reference/messaging/link-unfurling#authenticated_unfurls things still to add: https://api.slack.com/methods/chat.unfurl#arg_user_auth_required |
"Specifying |
@ds0nt Good point. I'll add them on Monday to the PR 🙂 |
@ds0nt done :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you.
Thanks! :D! |
This PR is basically a continuation of prior work by @kautsig in #839. I've just extracted his change into a separate branch for easier merging and added some test cases.
API changes
The Unfurl methods were added to be consistent with the UnfurlMessage method already exposed by the client.