Handle token_revoked event #892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanata2
reviewed
Feb 7, 2021
| @@ -162,6 +162,7 @@ func (smc *Client) connect(ctx context.Context, connectionCount int, additionalP | |||
| errInvalidAuth = "invalid_auth" | |||
| errInactiveAccount = "account_inactive" | |||
| errMissingAuthToken = "not_authed" | |||
| errInvalidToken = "invalid_token" | |||
There was a problem hiding this comment.
Does Slack send us to different errors for SocketMode and RTM??
There was a problem hiding this comment.
apologies, I messed up, it's the same error string. Fixing it
kanata2
added
the
feedback given
This is a critical event and the client should stop trying to reconnect. Signed-off-by: Andrea Barberio <insomniac@slackware.it>
insomniacslk
force-pushed
the
handle_token_revoked
branch
from
0e40c33
to
6df6591
Compare
|
Not sure why this is failing only on go 1.12, @kanata2 would you have an insight? |
kanata2
removed
the
feedback given
|
This test is so fragile... (I'll run test again.) |
insomniacslk
added a commit
to insomniacslk/irc-slack
that referenced
this pull request
Mar 16, 2021
In particular, improve reconnection behaviour after merging slack-go/slack#892 Signed-off-by: Andrea Barberio <insomniac@slackware.it>
insomniacslk
added a commit
to insomniacslk/irc-slack
that referenced
this pull request
Mar 16, 2021
In particular, improve reconnection behaviour after merging slack-go/slack#892 Signed-off-by: Andrea Barberio <insomniac@slackware.it>
This was referenced Mar 18, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a critical event and the client should stop trying to reconnect.
Signed-off-by: Andrea Barberio insomniac@slackware.it