link_shared message_ts field isn't always a number
#999
+40
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2021 21:38
|
Thanks! I'll release as soon as possible after merging this. |
kanata2
approved these changes
Nov 11, 2021
kanata2
reviewed
Nov 11, 2021
kanata2
approved these changes
Nov 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a one-liner, but a breaking change.
As documented in https://api.slack.com/events/link_shared, the
message_tsfield will not be a number if the event is generated from an unfurl in the compose message area (the feature was announced here: https://api.slack.com/changelog/2021-08-changes-to-unfurls).Includes a new test, which is the example payload from the
link_sharedurl above.Fixes #998