Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(3.x) GitHub actions and some other improvements #130

Open
wants to merge 100 commits into
base: main
Choose a base branch
from

Conversation

pedrofurtado
Copy link

@pedrofurtado pedrofurtado commented Oct 11, 2021

Hello, @stevenosloan @siegy22 ! 👋

Thank you for your hard work on this gem.

I opened this PR to propose some changes and improvements, such as:

  • Replacement of Travis CI to fully integrated CI/CD with Github Actions. It includes tests, lints, and deploy to Rubygems. The last one (deploy to Rubygems), once configured, can be made by "Actions" tab, dispatching the workflow manually or be triggered by a release/tag creation on repo. The two option are possible;
  • Configuration to rubocop run in all files except specs and gemspec, and fixes of offenses;
  • Dockerfile for other devs pull repo, make changes and test it in PC easily;
  • Renames of some special files (CHANGELOG, README for example) and some text changes;
  • Exclusion of feature for multiple-channel message sending, because Slack does not provide this anymore;
  • README improvements

Let me know what you think about 🍻 🤝

PS: Some secrets are required to be configured, for Rubygems deploy. I can explain for you the steps to be done 👍

PS 2: The gem internal structure was changed, because of this I've changed version to 3.x 🔍

PS 3: Dont worry the amount of files changed 😄 , the gem keeps stable and with test suite running well in Rubies from 2.0 until 3.0, JRuby and TruffleRuby 🎉

@pedrofurtado pedrofurtado changed the title GitHub actions and some other improvements (3.x) GitHub actions and some other improvements Oct 12, 2021
@pedrofurtado
Copy link
Author

Your eyes/review on it will be awesome 🕺 🏆 @stevenosloan @siegy22

@pedrofurtado
Copy link
Author

👀

@siegy22
Copy link
Contributor

siegy22 commented Jan 11, 2022

Thank you very much for working on this, I need @stevenosloan to respond first if he's willing to give maintenance control to me. 😄

@pedrofurtado
Copy link
Author

@siegy22 🎉 🤝

@stevenosloan
Copy link
Member

@siegy22 sorry about that, you should have an invite to be a maintainer -- I *thought* I'd done that when I split this off to an org instead of my personal, but that appears not to have been the case 😬

@pedrofurtado
Copy link
Author

Any news about this PR? 👀 😄

@siegy22
Copy link
Contributor

siegy22 commented May 24, 2022

@stevenosloan Can you re-send the invitation, I tried accepting it, but it was already expired 😞

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants