Check for Deprecated on method page #55
Conversation
|
@dblock It’s been quite a while since I contributed to the Slack gems. I just haven’t been working on Slack bots the last few years. But I recently had to patch our company’s bot to work with |
|
Thanks @kstole! Want to help me maintain this repo? Then you can create some hacktoberfest labels :) |
| @@ -36,7 +36,9 @@ def process_list(page, _default_data = {}) | |||
|
|
|||
| def process_method(page, default_data = {}) | |||
| method_page = ensure!(page, '.apiMethodPage', default_data[:method_name]) | |||
| desc = method_page.search('.apiReference__mainDescription').text.gsub("’", "'") | |||
| desc = method_page.search('.apiReference__mainDescription').text.gsub('’', "'") | |||
| return if desc.downcase.start_with? 'deprecated:' | |||
There was a problem hiding this comment.
Shouldn't this change the value of deprecated: below instead?
There was a problem hiding this comment.
It looks like that used to be the behavior but was changed in #48 to hardcode 'deprecated' => false and just remove any deprecated methods, so this is an extra check for when isDeprecated isn't accurate
|
Consider separating the |
kstole
force-pushed
the
deprecated_desc
branch
from
8e6a052
to
067960b
Compare
Yeah for sure. Happy to help maintain |
Added you, https://github.com/slack-ruby/slack-api-ref/invitations. Please continue making PRs, but feel free to merge others' and make labels as you please. |
#48 updated the spiders to grab methods from JSON data included on the Web API methods page. As noted in this comment, the deprecation info in that data can be inaccurate.
This change continues using that deprecation data but also checks for an individual method reference page labeling the method deprecated (as is the case for
rtm.start).