-
-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade rubocop to v1.47 #165
Upgrade rubocop to v1.47 #165
Conversation
5c8bab7
to
3939223
Compare
It's soooo weird that rubocop passes on my machine, with the exactly same ruby version with the ci. ❯ ruby --version
ruby 3.1.3p185 (2022-11-24 revision 1a6b16756e) [x86_64-linux]
Inspecting 67 files
...................................................................
67 files inspected, no offenses detected But 2 offences are detected in the ci and it doesn't pass. 🤔 |
Your local is probably not running the same version of Rubocop. Enable all cops (AllCops/Enabled: true) and then run |
It turns out that |
Actually need to revert the rubocop run, because it broke some working code. Working on it. |
8800794
to
78582ee
Compare
So let me know if running rubocop on ruby 3.1 may have any problem. I'm not sure. |
Yeah you should be targeting the minimum version of Ruby we support, which is 2.6 I believe looking at CI, otherwise it might generate code that doesn’t work. |
Got it. I'll do. |
Generated by 🚫 Danger |
Done. @dblock |
chore(ci): correct lint workflow name, use checkout v3 docs: add changelog entry
e0246bf
to
d696a72
Compare
TargetRubyVersion
in Rubocop config is the oldest officially supported Ruby version(currently 2.6).