Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added PostgreSQL support, closes #7. #48

Merged
merged 1 commit into from
Mar 7, 2017
Merged

Conversation

dblock
Copy link
Collaborator

@dblock dblock commented Mar 6, 2017

This now works, but there's no cursor pagination in API responses ala https://github.com/mongoid/mongoid-scroll. I think we need to fix that with at least some pagination support before merging.

@dblock dblock force-pushed the postgresql branch 2 times, most recently from 02c4b0e to 9eb7437 Compare March 6, 2017 21:44
@dblock
Copy link
Collaborator Author

dblock commented Mar 6, 2017

cc: @zachfeldman @spencerldixon

README.md Outdated

### PostgreSQL

Use the [pg](https://github.com/ged/ruby-pg) interface. Configure the database connection in `postgresql.yml`. See the [PostgreSQL example](sample_apps/sample_app_pg) for more information.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you're referring to Mongoid up there, you may want to say you're using ActiveRecord down here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. I guess what really should happen is that pg is just one of the examples and we can use any ActiveRecord compatible database.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah! I mean that actually opens things up a lot, kind of interesting. ActiveRecord has adapters for SQlite3 and several other DBMSs, I think.

@zachfeldman
Copy link

Very cool @dblock ! Sorry I didn't have the time/motivation to finish this. Haven't tested the PR but looking over it, it looks pretty well organized.

@dblock dblock force-pushed the postgresql branch 4 times, most recently from e733e4a to 5cbb5e9 Compare March 7, 2017 15:00
@dblock
Copy link
Collaborator Author

dblock commented Mar 7, 2017

I have a green build & al, merging.

@dblock dblock merged commit ae67893 into slack-ruby:master Mar 7, 2017
@dblock dblock deleted the postgresql branch March 7, 2017 15:12
@dblock
Copy link
Collaborator Author

dblock commented Mar 7, 2017

I'm going to cut a release soon, if anyone wants to try this out from master, that'd be great.

@dblock
Copy link
Collaborator Author

dblock commented Mar 12, 2017

Released AR support in 0.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants