-
-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added PostgreSQL support, closes #7. #48
Conversation
02c4b0e
to
9eb7437
Compare
README.md
Outdated
|
||
### PostgreSQL | ||
|
||
Use the [pg](https://github.com/ged/ruby-pg) interface. Configure the database connection in `postgresql.yml`. See the [PostgreSQL example](sample_apps/sample_app_pg) for more information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're referring to Mongoid up there, you may want to say you're using ActiveRecord down here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. I guess what really should happen is that pg
is just one of the examples and we can use any ActiveRecord compatible database.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah! I mean that actually opens things up a lot, kind of interesting. ActiveRecord has adapters for SQlite3 and several other DBMSs, I think.
Very cool @dblock ! Sorry I didn't have the time/motivation to finish this. Haven't tested the PR but looking over it, it looks pretty well organized. |
e733e4a
to
5cbb5e9
Compare
I have a green build & al, merging. |
I'm going to cut a release soon, if anyone wants to try this out from master, that'd be great. |
Released AR support in 0.6.0. |
This now works, but there's no cursor pagination in API responses ala https://github.com/mongoid/mongoid-scroll. I think we need to fix that with at least some pagination support before merging.