Initialize the App class .instance is called on #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmvt
changed the title
|
Very nice. I'd love a CHANGELOG entry and a test for this, please? |
|
happy to... will update this evening |
|
Bump @dmvt, want to cut a release soon would be nice to get this. |
|
Sorry I missed the cut |
| @@ -1,5 +1,6 @@ | |||
| ### 0.5.1 (Next) | |||
|
|
|||
| * [#33](https://github.com/dblock/slack-ruby-bot/pull/33): `SlackRubyBot::App.instance` now creates an instance of the class on which it is called. | |||
There was a problem hiding this comment.
Make this look like all the other changelog lines with a link to your Github profile.
|
No big deal, next cut. Can you squash your commits, too, please. |
Initializes the subclass (for instance `PongBot::App` in the first `README` example) instead of `SlackRubyBot::App` specifically. This allows for easier behavior modification through custom `Hooks` and direct method overriding.
|
All set :) |
|
👍 |
dblock
added a commit
that referenced
this pull request
Dec 7, 2015
Initialize the App class .instance is called on
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializes the subclass (for instance
PongBot::Appin the firstREADMEexample) instead ofSlackRubyBot::Appspecifically. This allows for easier behavior modification through customHooksand direct method overriding.