Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove faye #357

Merged
merged 1 commit into from
Jan 24, 2021
Merged

Remove faye #357

merged 1 commit into from
Jan 24, 2021

Conversation

wasabigeek
Copy link
Contributor

Fixes #338

@wasabigeek wasabigeek marked this pull request as ready for review January 21, 2021 13:30
@dangerpr-bot
Copy link

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@dblock
Copy link
Collaborator

dblock commented Jan 21, 2021

Rebase, squash, and this is good to go! Thank you.

@dblock dblock mentioned this pull request Jan 22, 2021
Closed
@wasabigeek
Remove faye
8c80837 
Add changelog

Remove faye from CI

Improve readme
@dblock dblock merged commit 463160d into slack-ruby:master Jan 24, 2021
@wasabigeek wasabigeek deleted the remove-faye branch January 24, 2021 08:19
This was referenced Jan 27, 2021
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove support for multiple concurrency libraries
3 participants
@wasabigeek @dangerpr-bot @dblock