Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update API from slack-api-ref@f2e768a #493

Merged
merged 1 commit into from
Sep 17, 2023
Merged

Update API from slack-api-ref@f2e768a #493

merged 1 commit into from
Sep 17, 2023

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Aug 25, 2023 •
edited

Update API from slack-api-ref.
Rev: f2e768a
Date: 2023-09-16

@dangerpr-bot
Copy link

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@github-actions
Copy link
Author

Pull Request Test Coverage Report for Build 5981274864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+4.6%) to 88.465%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/stores/store.rb 4 77.98%
lib/slack/real_time/concurrency/async.rb 28 1.39%
Totals Coverage Status
Change from base Build 5964606720: 4.6%
Covered Lines: 4847
Relevant Lines: 5479
💛 - Coveralls

1 similar comment
@github-actions
Copy link
Author

Pull Request Test Coverage Report for Build 5981274864

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 34 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+4.6%) to 88.465%
Files with Coverage Reduction New Missed Lines %
spec/slack/real_time/concurrency/clients/async_spec.rb 1 87.5%
spec/slack/real_time/concurrency/with_concurrency_spec.rb 1 80.0%
lib/slack/real_time/stores/store.rb 4 77.98%
lib/slack/real_time/concurrency/async.rb 28 1.39%
Totals Coverage Status
Change from base Build 5964606720: 4.6%
Covered Lines: 4847
Relevant Lines: 5479
💛 - Coveralls

@coveralls
Copy link

coveralls commented Aug 25, 2023 •
edited

Pull Request Test Coverage Report for Build 6210145758

  • 125 of 141 (88.65%) changed or added relevant lines in 14 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+5.2%) to 89.079%
Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/admin_workflows_permissions.rb 7 8 87.5%
lib/slack/web/api/endpoints/admin_apps_config.rb 9 11 81.82%
lib/slack/web/api/endpoints/admin_functions_permissions.rb 10 12 83.33%
lib/slack/web/api/endpoints/admin_workflows_collaborators.rb 11 13 84.62%
lib/slack/web/api/endpoints/admin_functions.rb 7 11 63.64%
lib/slack/web/api/endpoints/admin_workflows.rb 8 13 61.54%
Totals Coverage Status
Change from base Build 5964606720: 5.2%
Covered Lines: 5008
Relevant Lines: 5622
💛 - Coveralls

@dblock dblock merged commit 2b654eb into master Sep 17, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dangerpr-bot @coveralls @dblock @web-flow