Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API from slack-api-ref@bc54564 #504

Merged
merged 1 commit into from
Jan 31, 2024
Merged

Conversation

github-actions[bot]
Copy link

@github-actions github-actions bot commented Nov 2, 2023

Update API from slack-api-ref.
Rev: bc54564
Date: 2024-01-30

@github-actions github-actions bot force-pushed the automated-api-update branch 2 times, most recently from d963010 to 1dbacc5 Compare November 13, 2023 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 3 times, most recently from a6017b3 to 4c33d82 Compare November 27, 2023 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 2 times, most recently from c0a96f4 to 17c2291 Compare December 5, 2023 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 3 times, most recently from cc410c4 to f60ae3e Compare December 14, 2023 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 3 times, most recently from 219b5f0 to 7259f3a Compare December 20, 2023 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 2 times, most recently from 570fc0e to 2250ae3 Compare January 15, 2024 23:20
@github-actions github-actions bot force-pushed the automated-api-update branch 4 times, most recently from 692de9f to 6099d10 Compare January 24, 2024 23:20
@saimedhi
Copy link

@dblock, I believe this bot is failing to update the changelog. Please correct me if I'm mistaken. I've implemented a similar bot for opensearch-py, and everything else seems to be working correctly except for the changelog update.

@dangerpr-bot
Copy link

1 Warning
⚠️ There're library changes, but not tests. That's OK as long as you're refactoring existing code.

Generated by 🚫 Danger

@dblock
Copy link
Collaborator

dblock commented Jan 30, 2024

@saimedhi good catch, I believe the problem is in peter-evans/create-pull-request@v5 that now does a Resetting working base branch 'master', so when it updates CHANGELOG it doesn't push the update onto the right branch.

Fixed in 015f615

Copy link
Author

Pull Request Test Coverage Report for Build 7718744896

  • -1 of 37 (97.3%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 88.62%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/functions.rb 13 14 92.86%
Totals Coverage Status
Change from base Build 7718739724: -0.5%
Covered Lines: 5054
Relevant Lines: 5703

💛 - Coveralls

@coveralls
Copy link

coveralls commented Jan 30, 2024

Pull Request Test Coverage Report for Build 7718744896

  • 36 of 37 (97.3%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.5%) to 88.62%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/slack/web/api/endpoints/functions.rb 13 14 92.86%
Totals Coverage Status
Change from base Build 7718739724: -0.5%
Covered Lines: 5054
Relevant Lines: 5703

💛 - Coveralls

@dblock dblock merged commit d3da145 into master Jan 31, 2024
12 of 19 checks passed
@dblock dblock deleted the automated-api-update branch January 31, 2024 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants