Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESLint Config Migration: Fix import/order lint rules failing #1031

Merged
merged 1 commit into from
Aug 4, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 4, 2021

Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

No ESLint config changes here - just getting the import/order rule passing. Nothing too controversial in here!

Impact

#1024 lint failures progress as of posting this PR:

✖ 927 problems (737 errors, 190 warnings)
  187 errors and 0 warnings potentially fixable with the `--fix` option.

Failures with this PR included:

✖ 903 problems (713 errors, 190 warnings)
  163 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 4, 2021
@filmaj filmaj self-assigned this Aug 4, 2021
@filmaj filmaj added enhancement M-T: A feature request for new functionality tests M-T: Testing work only and removed untriaged labels Aug 4, 2021
@filmaj filmaj merged commit bdc5efb into tslint-to-eslint Aug 4, 2021
@filmaj filmaj changed the title [WIP] ESLint Config Migration: Fix import/order lint rules failing ESLint Config Migration: Fix import/order lint rules failing Aug 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant