Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] ESLint Config Migration: Expand import/no-internal-modules allowlist #1032

Merged
merged 1 commit into from
Aug 23, 2021

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 4, 2021

Summary

This is a PR that should be merged into #1024 and incrementally addresses #842.

This PR expands the list of source directories that one may reach into its subdirectories to import individual submodules (details about the `import/no-internal-modules rule here).

The src/receivers directory has no single export - so I think it is safe to allow it there (similar structure to src/middleware). I am less sure of the src/types directory. What do you think @misscoded ?

Impact

Before

✖ 362 problems (173 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

After

✖ 350 problems (161 errors, 189 warnings)
  76 errors and 0 warnings potentially fixable with the `--fix` option.

Requirements (place an x in each [ ])

@filmaj filmaj added enhancement M-T: A feature request for new functionality tests M-T: Testing work only labels Aug 4, 2021
@filmaj filmaj requested a review from misscoded August 4, 2021 19:39
@filmaj filmaj self-assigned this Aug 4, 2021
@srajiang srajiang added this to the 3.6.0 milestone Aug 4, 2021
@filmaj filmaj force-pushed the import-no-internal-modules branch from 81b873a to bf75bc4 Compare August 9, 2021 21:54
@filmaj filmaj requested a review from seratch August 9, 2021 21:55
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/index.ts has * exports from types/index.ts. Thus, I think this should be fine

@srajiang srajiang modified the milestones: 3.6.0, 3.7.0 Aug 19, 2021
@filmaj filmaj merged commit b016cf7 into tslint-to-eslint Aug 23, 2021
@filmaj filmaj deleted the import-no-internal-modules branch August 23, 2021 17:06
@seratch seratch removed this from the 3.7.0 milestone Aug 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants