Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TS 4.4] Expand test coverage for HTTPReceiver #1094

Merged
merged 1 commit into from
Aug 27, 2021
Merged

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented Aug 27, 2021

Summary

Issuing this pull request in the quest to support newer TS version. This simply expands the test coverage a bit for HTTPReceiver. The intention is to merge this into @srajiang's active PR adding new TS support in #1091.

  • Split HTTPReceiver request tests into own describe block
  • Add a test for invoking the installRedirectHandler

Requirements (place an x in each [ ])

@gitwave gitwave bot added the untriaged label Aug 27, 2021
@filmaj filmaj added tests M-T: Testing work only and removed untriaged labels Aug 27, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a good addition 👍

@codecov
Copy link

codecov bot commented Aug 27, 2021

Codecov Report

❗ No coverage uploaded for pull request base (ts-4.4@90081bd). Click here to learn what that means.
The diff coverage is n/a.

❗ Current head 75b34ba differs from pull request most recent head 0555bc9. Consider uploading reports for the commit 0555bc9 to get more accurate results
Impacted file tree graph

@@            Coverage Diff            @@
##             ts-4.4    #1094   +/-   ##
=========================================
  Coverage          ?   71.03%           
=========================================
  Files             ?       13           
  Lines             ?     1229           
  Branches          ?      365           
=========================================
  Hits              ?      873           
  Misses            ?      287           
  Partials          ?       69           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90081bd...0555bc9. Read the comment docs.

@filmaj filmaj merged commit fef4dc2 into ts-4.4 Aug 27, 2021
@filmaj filmaj deleted the ts-4.4-coverage branch August 27, 2021 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests M-T: Testing work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants