Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a link issue in Japanese document #1111

Merged
merged 1 commit into from
Sep 9, 2021
Merged

Fix a link issue in Japanese document #1111

merged 1 commit into from
Sep 9, 2021

Conversation

risto24
Copy link
Contributor

@risto24 risto24 commented Sep 8, 2021

Summary

Fix missing bracket for JP document.

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only labels Sep 9, 2021
@seratch seratch added this to the 3.7.0 milestone Sep 9, 2021
@seratch
Copy link
Member

seratch commented Sep 9, 2021

Hi @risto24, thanks for fixing this issue! Once the CI builds pass, we'll merge your contribution 🎉

@codecov
Copy link

codecov bot commented Sep 9, 2021

Codecov Report

Merging #1111 (a2dad52) into main (72b28a7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1111   +/-   ##
=======================================
  Coverage   69.31%   69.31%           
=======================================
  Files          13       13           
  Lines        1284     1284           
  Branches      380      380           
=======================================
  Hits          890      890           
  Misses        320      320           
  Partials       74       74           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72b28a7...a2dad52. Read the comment docs.

@seratch seratch merged commit ee18b1c into slackapi:main Sep 9, 2021
@seratch seratch changed the title Fix missing bracket Fix a link issue in Japanese document Sep 9, 2021
@risto24 risto24 deleted the fix-typo branch September 9, 2021 00:32
@seratch seratch self-assigned this Sep 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants