Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Oauth with ExpressReceiver example app #1129

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

srajiang
Copy link
Member

Summary

Fixes #715 by adding an example app for Oauth with ExpressReceiver.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1129 (5f76742) into main (ee18b1c) will increase coverage by 1.60%.
The diff coverage is 88.57%.

❗ Current head 5f76742 differs from pull request most recent head d457c00. Consider uploading reports for the commit d457c00 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1129      +/-   ##
==========================================
+ Coverage   69.31%   70.92%   +1.60%     
==========================================
  Files          13       14       +1     
  Lines        1284     1324      +40     
  Branches      380      392      +12     
==========================================
+ Hits          890      939      +49     
+ Misses        320      311       -9     
  Partials       74       74              
Impacted Files Coverage Δ
src/receivers/SocketModeReceiver.ts 84.93% <85.36%> (+17.71%) ⬆️
src/receivers/HTTPReceiver.ts 34.87% <85.71%> (+2.59%) ⬆️
src/receivers/custom-routes.ts 94.44% <94.44%> (ø)
src/App.ts 83.60% <100.00%> (+0.04%) ⬆️
src/errors.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ada220...d457c00. Read the comment docs.

@srajiang srajiang self-assigned this Sep 24, 2021
@srajiang srajiang added the area:examples issues related to example or sample code label Sep 24, 2021
@srajiang srajiang added this to the 3.7.0 milestone Sep 24, 2021
Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@seratch seratch merged commit fd5d289 into slackapi:main Sep 24, 2021
@srajiang srajiang deleted the 715-express-oauth-example branch September 24, 2021 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:examples issues related to example or sample code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document using OAuth with an instance of ExpressReceiver
2 participants