Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs on updating views on submission with response_action #1130

Merged
merged 1 commit into from
Sep 24, 2021

Conversation

srajiang
Copy link
Member

@srajiang srajiang commented Sep 24, 2021

Summary

Fixes #1124. Can put in Python SDK docs changes after this is reviewed.

Requirements (place an x in each [ ])

@srajiang srajiang added the docs M-T: Documentation work only label Sep 24, 2021
@srajiang srajiang self-assigned this Sep 24, 2021
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #1130 (097d902) into main (ee18b1c) will increase coverage by 1.60%.
The diff coverage is 88.57%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1130      +/-   ##
==========================================
+ Coverage   69.31%   70.92%   +1.60%     
==========================================
  Files          13       14       +1     
  Lines        1284     1324      +40     
  Branches      380      392      +12     
==========================================
+ Hits          890      939      +49     
+ Misses        320      311       -9     
  Partials       74       74              
Impacted Files Coverage Δ
src/receivers/SocketModeReceiver.ts 84.93% <85.36%> (+17.71%) ⬆️
src/receivers/HTTPReceiver.ts 34.87% <85.71%> (+2.59%) ⬆️
src/receivers/custom-routes.ts 94.44% <94.44%> (ø)
src/App.ts 83.60% <100.00%> (+0.04%) ⬆️
src/errors.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7ada220...097d902. Read the comment docs.

@seratch seratch added this to the 3.7.0 milestone Sep 24, 2021
@seratch
Copy link
Member

seratch commented Sep 24, 2021

Let me merge this one now. We can track the progress for the corresponding Japanese page by #1131

@seratch seratch merged commit 2f3f499 into slackapi:main Sep 24, 2021
@srajiang srajiang deleted the 1124_docs branch September 24, 2021 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve view_submission listener document to mention ack() + response_action patterns
2 participants