Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Custom HTTP Routes Documentation #1136

Merged
merged 3 commits into from
Sep 29, 2021

Conversation

misscoded
Copy link
Contributor

Summary

Update Custom HTTP Routes section of documentation to include the newly introduced way to add custom routes. Move ExpressReceiver approach to its own (accordion) section.

Screen Shot 2021-09-28 at 3 32 01 PM

Requirements (place an x in each [ ])

@misscoded misscoded added the docs M-T: Documentation work only label Sep 28, 2021
@codecov
Copy link

codecov bot commented Sep 28, 2021

Codecov Report

Merging #1136 (39eba05) into main (ef7ce04) will not change coverage.
The diff coverage is n/a.

❗ Current head 39eba05 differs from pull request most recent head 2ae7c05. Consider uploading reports for the commit 2ae7c05 to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1136   +/-   ##
=======================================
  Coverage   71.71%   71.71%           
=======================================
  Files          15       15           
  Lines        1354     1354           
  Branches      402      402           
=======================================
  Hits          971      971           
  Misses        312      312           
  Partials       71       71           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ef7ce04...2ae7c05. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🍾

Copy link
Member

@srajiang srajiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I left some small suggestions.

docs/_advanced/custom_routes.md Outdated Show resolved Hide resolved
docs/_advanced/custom_routes.md Outdated Show resolved Hide resolved
misscoded and others added 2 commits September 28, 2021 16:38
Co-authored-by: Sarah Jiang <srajiang@gmail.com>
Co-authored-by: Sarah Jiang <srajiang@gmail.com>
@misscoded misscoded merged commit 91037be into slackapi:main Sep 29, 2021
@seratch seratch added this to the 3.7.0 milestone Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants