Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add documentation for socket mode and developer mode #1218

Merged
merged 5 commits into from
Nov 26, 2021

Conversation

TheManWhoStaresAtCode
Copy link
Contributor

Summary

Provide some basic documentation of the developer mode - as far as I understand it from the provided information in #714 and #742. Is related to #749.
As I mention the undocumented socket mode I documented this option as well.

Requirements (place an x in each [ ])

@codecov
Copy link

codecov bot commented Nov 25, 2021

Codecov Report

Merging #1218 (c945e7a) into main (4158bc5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1218   +/-   ##
=======================================
  Coverage   73.20%   73.20%           
=======================================
  Files          17       17           
  Lines        1437     1437           
  Branches      431      431           
=======================================
  Hits         1052     1052           
  Misses        300      300           
  Partials       85       85           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4158bc5...c945e7a. Read the comment docs.

@seratch seratch added the docs M-T: Documentation work only label Nov 26, 2021
@seratch seratch added this to the 3.9.0 milestone Nov 26, 2021
Co-authored-by: Kazuhiro Sera <seratch@gmail.com>
Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey, this is great, thank you for the pull request! I left a couple of minor grammar / phrasing tweaks.

This is great first step for #749, but I think this alone doesn't resolve that issue. I agree with @stevengill's opinion in #749 that we should also expand the guide / tutorial docs. I'll leave some ideas on that in #749 - if you'd like to take a stab at writing that as well, we would welcome any additional pull requests!

docs/_tutorials/reference.md Outdated Show resolved Hide resolved
docs/_tutorials/reference.md Outdated Show resolved Hide resolved
@filmaj filmaj merged commit b366702 into slackapi:main Nov 26, 2021
@filmaj
Copy link
Contributor

filmaj commented Nov 26, 2021

Thanks for addressing the changes and the PR! Very much appreciated 🙏

@TheManWhoStaresAtCode TheManWhoStaresAtCode deleted the docs_developerMode_749 branch November 26, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants