Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add expires at in updateConversation context #1221

Merged
merged 4 commits into from
Nov 30, 2021
Merged

Conversation

shubhamjajoo
Copy link
Contributor

Summary

Fix issue : Context method updateConversation should accept expiration time
#190

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Nov 28, 2021

CLA assistant check
All committers have signed the CLA.

@seratch seratch added this to the 3.9.0 milestone Nov 29, 2021
@seratch seratch added the enhancement M-T: A feature request for new functionality label Nov 29, 2021
@seratch seratch self-assigned this Nov 29, 2021
@seratch
Copy link
Member

seratch commented Nov 29, 2021

Hi @shubhamjajoo, thanks for taking the time to submit this PR! The change looks good me but can you add some tests to https://github.com/slackapi/bolt-js/blob/main/src/conversation-store.spec.ts for verifying the behavior changes?

@shubhamjajoo
Copy link
Contributor Author

shubhamjajoo commented Nov 30, 2021

Hi, @seratch , Added the test for the same.

Copy link
Member

@seratch seratch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Nov 30, 2021

Codecov Report

Merging #1221 (52667fe) into main (9feb878) will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1221      +/-   ##
==========================================
+ Coverage   73.20%   73.22%   +0.01%     
==========================================
  Files          17       17              
  Lines        1437     1438       +1     
  Branches      431      431              
==========================================
+ Hits         1052     1053       +1     
  Misses        300      300              
  Partials       85       85              
Impacted Files Coverage Δ
src/conversation-store.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9feb878...52667fe. Read the comment docs.

@seratch seratch merged commit 0fc421e into slackapi:main Nov 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants