Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update code snippet format in OAuth docs #1319

Merged
merged 1 commit into from
Feb 15, 2022

Conversation

horeaporutiu
Copy link
Contributor

@horeaporutiu horeaporutiu commented Feb 15, 2022

improves on #1306. Currently the highlights look inconsistent. This change should make them consistent.
Fixes #1318

Summary

Describe the goal of this PR. Mention any related Issue numbers.

Requirements (place an x in each [ ])

@horeaporutiu horeaporutiu self-assigned this Feb 15, 2022
@codecov
Copy link

codecov bot commented Feb 15, 2022

Codecov Report

Merging #1319 (e12fd83) into main (5e64acd) will not change coverage.
The diff coverage is n/a.

❗ Current head e12fd83 differs from pull request most recent head 3910d5e. Consider uploading reports for the commit 3910d5e to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1319   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines        1479     1479           
  Branches      442      442           
=======================================
  Hits         1078     1078           
  Misses        311      311           
  Partials       90       90           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e64acd...3910d5e. Read the comment docs.

@seratch
Copy link
Member

seratch commented Feb 15, 2022

Indeed, it's not great:

@seratch seratch merged commit e52252b into main Feb 15, 2022
@seratch seratch deleted the update-code-snippet-format-oauth branch February 15, 2022 22:15
@horeaporutiu
Copy link
Contributor Author

Screen Shot 2022-02-15 at 2 16 46 PM

Looks better now!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants