Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote add to slack URL #1323

Merged
merged 2 commits into from
Feb 22, 2022
Merged

Conversation

nicolls1
Copy link
Contributor

Summary

I needed to customize the install route and I noticed that the href URL isn't quoted.

Requirements (place an x in each [ ])

@CLAassistant
Copy link

CLAassistant commented Feb 18, 2022

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #1323 (697301b) into main (7891454) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1323   +/-   ##
=======================================
  Coverage   72.88%   72.88%           
=======================================
  Files          17       17           
  Lines        1479     1479           
  Branches      442      442           
=======================================
  Hits         1078     1078           
  Misses        311      311           
  Partials       90       90           
Impacted Files Coverage Δ
src/receivers/render-html-for-install-path.ts 75.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7891454...697301b. Read the comment docs.

@mwbrooks mwbrooks self-assigned this Feb 18, 2022
@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch labels Feb 18, 2022
@mwbrooks mwbrooks added this to the 3.10.0 milestone Feb 18, 2022
@mwbrooks
Copy link
Member

Hi @nicolls1 👋🏻

Thanks a lot for the pull request and congrats on your first-contribution to bolt-js!

Before we can approve and merge your pull request, can you please sign the CLA (Contributor License Agreement)? 🙇🏻

@nicolls1
Copy link
Contributor Author

Sorry, just had to double check it with my company but good to go now!

@nicolls1
Copy link
Contributor Author

Merging was blocked by being behind master and is now blocked by waiting for workflow. Feel free to merge or I can after workflow approval :)

@filmaj filmaj merged commit 67b194f into slackapi:main Feb 22, 2022
@nicolls1 nicolls1 deleted the quote-install-button-href branch February 22, 2022 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:patch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants