Add FileInstallationStore to OAuth docs #1329
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1329 +/- ##
=======================================
Coverage 72.72% 72.72%
=======================================
Files 17 17
Lines 1463 1463
Branches 436 436
=======================================
Hits 1064 1064
Misses 310 310
Partials 89 89 Continue to review full report at Codecov.
|
srajiang
commented
Feb 23, 2022
| @@ -24,20 +62,18 @@ const app = new App({ | |||
| clientSecret: process.env.SLACK_CLIENT_SECRET, | |||
| stateSecret: 'my-state-secret', | |||
| scopes: ['chat:write'], | |||
| // optional code for directInstall. Defaults to false. When set to true, user does not see "Add to Slack" button page. | |||
There was a problem hiding this comment.
I felt that including this additional code block was adding additional bloat to an already pretty big section. I've added a git permalink instead that points to the lines in the example oauth app where directInstall option can be seen clearly.
srajiang
commented
Feb 23, 2022
srajiang
force-pushed
the
docs-improve-auth
branch
from
5efcc2b
to
ddf96a0
Compare
seratch
reviewed
Feb 23, 2022
| @@ -24,20 +62,18 @@ const app = new App({ | |||
| clientSecret: process.env.SLACK_CLIENT_SECRET, | |||
| stateSecret: 'my-state-secret', | |||
| scopes: ['chat:write'], | |||
| // optional code for directInstall. Defaults to false. When set to true, user does not see "Add to Slack" button page. | |||
srajiang
force-pushed
the
docs-improve-auth
branch
from
ddf96a0
to
c3d09e4
Compare
10 tasks
misscoded
approved these changes
Feb 23, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1305 by adding a section that describes how to use
FileInstallationStoreto speed up development of oauth app.Additionally, this OAuth documentation has gotten bloated due to lots of necessary and good elaboration and detail added over time. I've done my best to cut down some of that bloat while retaining the essential points.
Reviewers if you could build the docs locally and just give me feedback on whether this has improved readability that'd be great.
Requirements (place an
xin each[ ])