Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use npx instead of npm exec to support npm 6+ #1451

Merged
merged 1 commit into from May 11, 2022

Conversation

filmaj
Copy link
Contributor

@filmaj filmaj commented May 11, 2022

npm exec is not available in npm v6 (thanks for catching this @srajiang !) so moving to use npx instead, which is supported in older versions of npm.

This PR should be used in conjunction with srajiang/bolt-js-starter-template#2.

@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

❗ No coverage uploaded for pull request base (add-app-function@cf159db). Click here to learn what that means.
The diff coverage is n/a.

@@                 Coverage Diff                 @@
##             add-app-function    #1451   +/-   ##
===================================================
  Coverage                    ?   79.73%           
===================================================
  Files                       ?       20           
  Lines                       ?     1609           
  Branches                    ?      465           
===================================================
  Hits                        ?     1283           
  Misses                      ?      220           
  Partials                    ?      106           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf159db...962d082. Read the comment docs.

@srajiang srajiang requested a review from mwbrooks May 11, 2022 16:40
Copy link
Member

@mwbrooks mwbrooks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @srajiang! This worked for me using npm@8.4.1.

@mwbrooks mwbrooks added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor labels May 11, 2022
@filmaj
Copy link
Contributor Author

filmaj commented May 11, 2022

Ah yes I should mention I tested this with node v12.22.12 (npm v6.14.16), node v14.19.2 (npm v6.14.17) and node v16.14.0 (npm v8.3.1) - just based on what we currently have in the "engines" field of bolt's package.json.

@srajiang srajiang merged commit 77b7fd1 into add-app-function May 11, 2022
@filmaj filmaj deleted the cli-npx-for-older-versions branch May 11, 2022 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented semver:minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants