Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #1472 say argument does not exist for pin_* events in TS #1473

Merged
merged 1 commit into from Jun 3, 2022

Conversation

seratch
Copy link
Member

@seratch seratch commented Jun 3, 2022

Summary

This pull request resolves #1472. The current pin_added / pin_removed event data types are not compatible with https://github.com/slackapi/bolt-js/blob/%40slack/bolt%403.11.1/src/types/events/index.ts#L81-L83

Requirements (place an x in each [ ])

@seratch seratch added bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific labels Jun 3, 2022
@seratch seratch added this to the 3.11.2 milestone Jun 3, 2022
@seratch seratch requested review from filmaj and srajiang June 3, 2022 05:47
@seratch seratch self-assigned this Jun 3, 2022
@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #1473 (3192b5f) into main (23cc0e1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1473   +/-   ##
=======================================
  Coverage   81.97%   81.97%           
=======================================
  Files          18       18           
  Lines        1492     1492           
  Branches      435      435           
=======================================
  Hits         1223     1223           
  Misses        172      172           
  Partials       97       97           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23cc0e1...3192b5f. Read the comment docs.

Copy link
Contributor

@filmaj filmaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for this!

@wickerpopstar
Copy link

If it makes sense to fix it as a part of this ticket, the same problem exists for the reaction_added event.

Copy link

@wickerpopstar wickerpopstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. 👍 on the unit tests. Thanks for taking care of this so quickly!

@srajiang srajiang merged commit 41f0255 into slackapi:main Jun 3, 2022
@seratch seratch deleted the issue-1472-pinned-item-type branch June 3, 2022 22:34
seratch added a commit to seratch/bolt-js that referenced this pull request Jun 3, 2022
@seratch
Copy link
Member Author

seratch commented Jun 3, 2022

@wickerpopstar Thanks for reporting the same issue for reaction_added/reaction_removed events! I just sent one more PR for it: #1476

filmaj pushed a commit that referenced this pull request Jun 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug M-T: confirmed bug report. Issues are confirmed when the reproduction steps are documented TypeScript-specific
Projects
None yet
Development

Successfully merging this pull request may close these issues.

say type incorrectly inferred as never when using SlackEventMiddlewareArgs<'pin_added'>
4 participants