Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add customPropertiesExtractor to the documents #1477

Closed
4 of 10 tasks
seratch opened this issue Jun 6, 2022 · 4 comments · Fixed by #1864
Closed
4 of 10 tasks

Add customPropertiesExtractor to the documents #1477

seratch opened this issue Jun 6, 2022 · 4 comments · Fixed by #1864
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Milestone

Comments

@seratch
Copy link
Member

seratch commented Jun 6, 2022

Description

We forgot to add the document section for the customPropertiesExtractor, which was added in v3.8.0

What type of issue is this? (place an x in one of the [ ])

  • bug
  • enhancement (feature request)
  • question
  • documentation related
  • example code related
  • testing related
  • discussion

Requirements (place an x in each of the [ ])

  • I've read and understood the Contributing guidelines and have done my best effort to follow them.
  • I've read and agree to the Code of Conduct.
  • I've searched for any related issues and avoided creating a duplicate issue.
@seratch seratch added docs M-T: Documentation work only good first issue Good for newcomers labels Jun 6, 2022
@seratch seratch added this to the 3.x milestone Jun 6, 2022
@mlauter
Copy link
Contributor

mlauter commented May 18, 2023

@seratch do you imagine this going in the Customizing a receiver section or as a standalone docs section? Currently that customizing a receiver section just points folks to the source for ExpressReceiver for more info, and doesn't list or document receiver options.

Happy to take a stab at a PR for this -- just wanted to check in about what folks had in mind!

@mlauter
Copy link
Contributor

mlauter commented Jun 7, 2023

@seratch just wanted to check what you had in mind here^

@seratch
Copy link
Member Author

seratch commented Jun 8, 2023

Hi @mlauter, thanks for your interest. I was going to simply add it to https://slack.dev/bolt-js/reference#receiver-options If you're interested in working on it, we are happy to have your contribution!

@mlauter
Copy link
Contributor

mlauter commented Jun 8, 2023

Hi @mlauter, thanks for your interest. I was going to simply add it to https://slack.dev/bolt-js/reference#receiver-options If you're interested in working on it, we are happy to have your contribution!

got it that makes sense - lol, i've been reading these docs frequently for a long time now and never noticed the reference section in the sidebar, was just going to the source code 🤦 . I wonder if there's a way to make it more noticeable, it sort of gets lost in all the concept links in the sidebar.

mlauter added a commit to mlauter/bolt-js that referenced this issue Jun 8, 2023
mlauter added a commit to mlauter/bolt-js that referenced this issue Jun 8, 2023
@filmaj filmaj modified the milestones: 3.x, 3.13.2 Jun 8, 2023
filmaj added a commit that referenced this issue Jun 14, 2023
…1864)

* Fixes #1477 Add customPropertiesExtractor to receiver options docs

* Edit docs in response to feedback

* Link to specific docs subheading

---------

Co-authored-by: Fil Maj <maj.fil@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs M-T: Documentation work only good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants