Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set @types/node to set version 18.7.15 #1577

Conversation

hello-ashleyintech
Copy link
Contributor

Summary

Setting the @types/node package to a set version 18.7.15 due to a breaking change in 18.7.16

Requirements (place an x in each [ ])

@hello-ashleyintech hello-ashleyintech added the enhancement M-T: A feature request for new functionality label Sep 8, 2022
@hello-ashleyintech hello-ashleyintech self-assigned this Sep 8, 2022
@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #1577 (5cb9db4) into main (fb8950a) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #1577   +/-   ##
=======================================
  Coverage   82.01%   82.01%           
=======================================
  Files          18       18           
  Lines        1496     1496           
  Branches      436      436           
=======================================
  Hits         1227     1227           
  Misses        172      172           
  Partials       97       97           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pjungermann
Copy link

Is it still necessary to keep this as set version?

@hello-ashleyintech
Copy link
Contributor Author

Hi, @pjungermann! We have since fixed this - the current @types/node version we have for Bolt is 18.16.3.

@hello-ashleyintech hello-ashleyintech deleted the bump-typescript-dependency branch May 8, 2023 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement M-T: A feature request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants