[HERMES-3750] Fix bug where missing .js file results in JSON.parse error #1587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srajiang
force-pushed
the
next-gen-manifest-hook
branch
from
a0cf5d9
to
b0af2c0
Compare
Codecov Report
@@ Coverage Diff @@
## next-gen #1587 +/- ##
===========================================
Coverage ? 80.64%
===========================================
Files ? 20
Lines ? 1767
Branches ? 502
===========================================
Hits ? 1425
Misses ? 221
Partials ? 121 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
srajiang
force-pushed
the
next-gen-manifest-hook
branch
from
b0af2c0
to
0ba4eef
Compare
srajiang
commented
Sep 12, 2022
| @@ -78,34 +100,7 @@ function find(currentPath, targetFilename) { | |||
| } | |||
| } | |||
|
|
|||
| function getManifestData(searchDir) { | |||
There was a problem hiding this comment.
Moved to separate file for easier module mocking
srajiang
added
the
bug
src/cli/hook-utils/manifest.js
Outdated
| /** | ||
| * Union merge of arrays | ||
| */ | ||
| export function unionMerge(array1, array2) { |
There was a problem hiding this comment.
@srajiang it seems like this export keyword here threw an error for me when running hermes manifest while testing. i think since it's getting exported via module.exports it should be good to remove this export keyword!
There was a problem hiding this comment.
full error I got:
🚫 Unable to get your app manifest details. Please check your manifest file:
A script hook defined in the Slack Configuration file (`slack.json`) returned an error (sdk_hook_invocation_failed)
Error Details:
1: Command for 'manifest' returned an error: exit status 1
/Users/ashley.huynh/Documents/Forked/bolt-js/src/cli/hook-utils/manifest.js:8
export function unionMerge(array1, array2) {
^^^^^^
SyntaxError: Unexpected token 'export'
at Object.compileFunction (node:vm:360:18)
at wrapSafe (node:internal/modules/cjs/loader:1049:15)
at Module._compile (node:internal/modules/cjs/loader:1084:27)
at Module._extensions..js (node:internal/modules/cjs/loader:1174:10)
at Module.load (node:internal/modules/cjs/loader:998:32)
at Module._load (node:internal/modules/cjs/loader:839:12)
at Module.require (node:internal/modules/cjs/loader:1022:19)
at require (node:internal/modules/cjs/helpers:102:18)
at Object.<anonymous> (/Users/ashley.huynh/Documents/Forked/bolt-js/src/cli/hook-utils/get-manifest-data.js:7:5)
at Module._compile (node:internal/modules/cjs/loader:1120:14)
Node.js v18.7.0
Suggestion:
Try to run `slack doctor` to check that your system dependencies are up-to-date.
There was a problem hiding this comment.
Good catch @ashleymcm 🙇♀️ - I've updated to remove the unnecessary export
srajiang
force-pushed
the
next-gen-manifest-hook
branch
from
27871a8
to
91fffd1
Compare
srajiang
commented
Sep 13, 2022
| @@ -16,12 +21,16 @@ function readManifestJSONFile(searchDir, filename) { | |||
| manifestJSON = JSON.parse(fs.readFileSync(jsonFilePath, 'utf8')); | |||
| } | |||
| } catch (error) { | |||
| return; | |||
| return null; | |||
There was a problem hiding this comment.
Now this is properly returning null instead of undefined
srajiang
changed the title
srajiang
added a commit
that referenced
this pull request
Sep 13, 2022
…ror (#1587) * Handle missing imported manifest (.js) * Add tests for getManifestData()
srajiang
added a commit
that referenced
this pull request
Sep 28, 2022
…ror (#1587) * Handle missing imported manifest (.js) * Add tests for getManifestData()
hello-ashleyintech
pushed a commit
that referenced
this pull request
Oct 14, 2022
…ror (#1587) * Handle missing imported manifest (.js) * Add tests for getManifestData()
srajiang
added a commit
that referenced
this pull request
Nov 11, 2022
…ror (#1587) * Handle missing imported manifest (.js) * Add tests for getManifestData()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
npm link&npm link @slack/bolthermes manifestandhermes manifest validateand a manifest should properly generateRequirements (place an
xin each[ ])